By: sole

sole — Wed, 27 Aug 2008 08:19:04 +0000

Hey! Thanks for the improved script. You’re right, it didn’t look for anything recursive, because for this specific case I hadn’t folders inside folders, only plain files.

By the way, I applied some formatting to your code :)

I didn’t know about yield in Python, and I’m glad to see how my supposition about imports was right. I think I’m in the right way :D

Thanks again for all!

By: Sergi Mansilla

Sergi Mansilla — Wed, 27 Aug 2008 07:50:52 +0000

Ugh it didn’t indent my code :(

By: Sergi Mansilla

Sergi Mansilla — Wed, 27 Aug 2008 07:50:15 +0000

Good work and good blog!

Your script seems likely to throw an error in the following lines:

for item_file in os.listdir(full_path):

                output_file.write(os.path.join(full_path, item_file), item_file)

given that you are handling files and folders at the same time, and as far as I can remember (not sure though), it will attempt to read the folder information as if it were a file to write its contents inside the .zip file. I think you should filter the folders out as you did already some lines before.

Here is my attempt at writing a recursive solution for the problem:

from os import listdir, walk, path

from os.path import join, isdir, exists

import sys

import zipfile



if len(sys.argv) > 1:

        folder = sys.argv[1]

else:

        folder = '.'



def dirwalk(dir):

    for root, dirs, files in walk(dir):

        for name in dirs:

            yield [root, name]



for ff, item in dirwalk(folder):

    folder_path = join(ff, item)



    dst_item = folder_path + '.zip'



    if not exists(dst_item):

        output_file = zipfile.ZipFile(dst_item, "w", zipfile.ZIP_DEFLATED)

        file_path = join(folder_path,file)

        for item_file in [file for file in listdir(folder_path) if not isdir(file_path)]:

            output_file.write(file_path, item_file)

        output_file.close()

Comments on: Create .ZIPs from multiple folders

By: sole

By: Sergi Mansilla

By: Sergi Mansilla